Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiler task for calling a credential helper. #16226

Closed
wants to merge 1 commit into from

Conversation

tjgq
Copy link
Contributor

@tjgq tjgq commented Sep 6, 2022

This might help debug future performance issues related caused by slow
credential helpers.

This might help debug future performance issues related caused by slow
credential helpers.
@tjgq tjgq requested a review from coeuvre September 6, 2022 14:59
@sgowroji sgowroji added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Sep 6, 2022
@tjgq
Copy link
Contributor Author

tjgq commented Sep 6, 2022

cc @Yannic

@tjgq
Copy link
Contributor Author

tjgq commented Sep 7, 2022

@bazel-io fork 5.3.1

@copybara-service copybara-service bot closed this in 9c0940d Sep 7, 2022
@Wyverald
Copy link
Member

Wyverald commented Sep 7, 2022

@bazel-io fork 5.3.1

ShreeM01 added a commit that referenced this pull request Sep 7, 2022
This might help debug future performance issues related caused by slow
credential helpers.

Closes #16226.

PiperOrigin-RevId: 472683449
Change-Id: Ib1f51a51763ccfa0e18be980fd4b4d77954a9814

Co-authored-by: Tiago Quelhas <tjgq@google.com>
Copy link
Contributor

@Yannic Yannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShreeM01 ShreeM01 removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 15, 2022
aiuto pushed a commit to aiuto/bazel that referenced this pull request Oct 12, 2022
This might help debug future performance issues related caused by slow
credential helpers.

Closes bazelbuild#16226.

PiperOrigin-RevId: 472683449
Change-Id: Ib1f51a51763ccfa0e18be980fd4b4d77954a9814
@tjgq tjgq deleted the profile-credhelper branch December 8, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants